On 10:22:58, 7.04.16, Martin Natano wrote:
> On Wed, Apr 06, 2016 at 03:42:20PM +0200, Michal Mazurek wrote:
> > MPSAFE is never used, and doesn't look like it's even supported (no
> > matching SY_MPSAFE anywhere).
>
> SY_MPSAFE seems to be unused since it's introduction in 2007 and it
> doesn't have any effect; ok natano@, if no one comes up with a reason to
> keep this.
Nearly a month later, nobody did come up with a reason to keep it.
> > Index: sys/kern/makesyscalls.sh
> > ===================================================================
> > RCS file: /cvs/src/sys/kern/makesyscalls.sh,v
> > retrieving revision 1.11
> > diff -u -p -r1.11 makesyscalls.sh
> > --- sys/kern/makesyscalls.sh 27 Nov 2007 18:04:01 -0000 1.11
> > +++ sys/kern/makesyscalls.sh 6 Apr 2016 12:53:28 -0000
> > @@ -255,10 +255,6 @@ function parseline() {
> > funcalias=""
> > end=NF
> > }
> > - if ($f == "MPSAFE") { # allow MP-safe syscalls
> > - sycall_flags = sprintf("SY_MPSAFE | %s", sycall_flags)
> > - f++
> > - }
> > if ($f == "NOLOCK") { # syscall does not need locks
> > sycall_flags = sprintf("SY_NOLOCK | %s", sycall_flags)
> > f++
> > Index: sys/sys/systm.h
> > ===================================================================
> > RCS file: /cvs/src/sys/sys/systm.h,v
> > retrieving revision 1.111
> > diff -u -p -r1.111 systm.h
> > --- sys/sys/systm.h 24 Mar 2016 08:57:51 -0000 1.111
> > +++ sys/sys/systm.h 6 Apr 2016 12:53:28 -0000
> > @@ -112,8 +112,7 @@ extern struct sysent { /* system call t
> > sy_call_t *sy_call; /* implementing function */
> > } sysent[];
> >
> > -#define SY_MPSAFE 0x01
> > -#define SY_NOLOCK 0x02
> > +#define SY_NOLOCK 0x01
> >
> > #if _BYTE_ORDER == _BIG_ENDIAN
> > #define SCARG(p, k) ((p)->k.be.datum) /* get arg from args
> > pointer */
> >
> > --
> > Michal Mazurek
> >
>
--
Michal Mazurek
