On Thu, May 12, 2016 at 08:39:01PM +0000, Miod Vallat wrote: > > > fcu(4) could benefit from a similar change, as there may be pwm fans > > > there too. At least RackMac3,1 has two pwm fans according to the eeprom > > > -p output. > > > > Hmm, looking at the fcu(4) code it already should support pwm fans, no? > > Doh! I was looking for `fan' in the sensors output and did not notice > `percent'. Sorry for the noise.
:-) That's exactly the reason why the first diff uses the rpm value in favour of the pwm percentage value. It's more intuitive to expect all fans to show up as a fan sensor type instead of a percentage type. But I guess since other drivers also use the percentage value for pwm fans it's more strict to keep this, hence the second diff.
