On Sun, May 15, 2016 1:22 pm, Juan Francisco Cantero Hurtado wrote:
> On Sun, May 15, 2016 at 06:43:16PM +0200, Jeremie Courreges-Anglas wrote:
>> "Ted Unangst" <[email protected]> writes:
>>
>> > i'm tired of seeing bug reports with no subject. i also get a fair bit
>> of spam
>> > with no subject and i am easily confused. something is better than
>> nothing.
>>
>> I fear that after that change all bug reports will only have [bug
>> report] as Subject. Something that wouldn't catch the eye of people
>> that might be able to understand and fix the problem.
>
Why not make Subject a required field? Might want to also add a comment
there like Category and Synopsis have.
Tim.
Index: sendbug.c
===================================================================
RCS file: /cvs/src/usr.bin/sendbug/sendbug.c,v
retrieving revision 1.74
diff -u -p -r1.74 sendbug.c
--- sendbug.c 17 Mar 2016 19:40:43 -0000 1.74
+++ sendbug.c 15 May 2016 21:10:00 -0000
@@ -513,7 +513,7 @@ checkfile(const char *pathname)
{
FILE *fp;
size_t len;
- int category = 0, synopsis = 0;
+ int category = 0, synopsis = 0, subject = 0;
char *buf;
if ((fp = fopen(pathname, "r")) == NULL) {
@@ -525,9 +525,11 @@ checkfile(const char *pathname)
category = 1;
else if (matchline(">Synopsis:", buf, len))
synopsis = 1;
+ else if (matchline("Subject:", buf, len))
+ subject = 1;
}
fclose(fp);
- return (category && synopsis);
+ return (category && synopsis && subject);
}
void
