On Thu, 26 May 2016 22:07:14 +0200, Martin Natano wrote:
> > diff -u -p -u -r1.11 Makefile
> > --- share/locale/ctype/Makefile 20 Mar 2016 15:45:40 -0000 1.11
> > +++ share/locale/ctype/Makefile 23 Mar 2016 20:16:56 -0000
> > @@ -9,8 +9,7 @@ NOMAN= # defined
> > all: UTF-8.out
> >
> > UTF-8.out: en_US.UTF-8.src
> > - ${CPP} < ${.CURDIR}/en_US.UTF-8.src | \
> > - sed -e '/^#/d' | mklocale -o ${.TARGET}
> > + ${CC} -E -P - < ${.CURDIR}/en_US.UTF-8.src | mklocale -o ${.TARGET}
>
> I think cpp can be dropped here. As far as I can tell it is only used to
> remove the comments, which mklocale can do by itself. The output stays
> the same with just this:
>
> mklocale -o ${.TARGET} ${.CURDIR}/en_US.UTF-8.src
I don't see anything in mklocale that handles C-style comments.
We can check the output:
$ cc -E -P - < en_US.UTF-8.src | mklocale -o foo
$ mklocale -o bar en_US.UTF-8.src
$ cmp foo bar
foo bar differ: char 3132, line 6
I think that file does need preprocessing.
- todd
