On Wed, Jun 01, 2016 at 01:08:05PM -0400, Ted Unangst wrote:
> I find this easier to read. My old eyes don't focus on the semicolon, which
> makes me wonder what's supposed to be happening.
Yes, please! ok natano@
>
>
> Index: pax/ar_io.c
> ===================================================================
> RCS file: /cvs/src/bin/pax/ar_io.c,v
> retrieving revision 1.55
> diff -u -p -r1.55 ar_io.c
> --- pax/ar_io.c 6 Dec 2015 16:57:45 -0000 1.55
> +++ pax/ar_io.c 1 Jun 2016 17:05:32 -0000
> @@ -427,7 +427,7 @@ ar_drain(void)
> * keep reading until pipe is drained
> */
> while ((res = read(arfd, drbuf, sizeof(drbuf))) > 0)
> - ;
> + continue;
> lstrval = res;
> }
>
> @@ -1038,7 +1038,7 @@ get_phys(void)
> * (this is a bit paranoid, but should be safe to do).
> */
> while ((res = read(arfd, scbuf, sizeof(scbuf))) > 0)
> - ;
> + continue;
> if (res < 0) {
> syswarn(1, errno, "Unable to locate tape filemark.");
> return(-1);
> Index: pax/ftree.c
> ===================================================================
> RCS file: /cvs/src/bin/pax/ftree.c,v
> retrieving revision 1.38
> diff -u -p -r1.38 ftree.c
> --- pax/ftree.c 19 Mar 2015 05:14:24 -0000 1.38
> +++ pax/ftree.c 1 Jun 2016 17:05:38 -0000
> @@ -548,7 +548,7 @@ getpathname(char *buf, int buflen)
> term = '\n';
> }
> while ((ch = getchar()) != term && ch != EOF)
> - ;
> + continue;
> paxwarn(1, "Ignoring too-long pathname: %s", buf);
> return(NULL);
> }
> Index: rmdir/rmdir.c
> ===================================================================
> RCS file: /cvs/src/bin/rmdir/rmdir.c,v
> retrieving revision 1.11
> diff -u -p -r1.11 rmdir.c
> --- rmdir/rmdir.c 9 Oct 2015 01:37:06 -0000 1.11
> +++ rmdir/rmdir.c 1 Jun 2016 17:05:58 -0000
> @@ -75,7 +75,7 @@ main(int argc, char *argv[])
> /* Delete trailing slashes, per POSIX. */
> p = *argv + strlen(*argv);
> while (--p > *argv && *p == '/')
> - ;
> + continue;
> *++p = '\0';
>
> if (rmdir(*argv) < 0) {
> @@ -96,7 +96,7 @@ rm_path(char *path)
> while ((p = strrchr(path, '/')) != NULL) {
> /* Delete trailing slashes. */
> while (--p > path && *p == '/')
> - ;
> + continue;
> *++p = '\0';
>
> if (rmdir(path) < 0) {
>
