The below error message sequence isn't as clear as it could be:

> mike:/home/mike$ doas pfctl -f /etc/pf. 
> pfctl: /etc/pf.: No such file or directory
> pfctl: cannot open the main config file!: No such file or directory
> pfctl: Syntax error in config file: pf rules not loaded

There are possible improvements other than the one below, but because
it's an ergonomic issue I figured I'd point it out and leave it to the
PF people.

Thanks,
Mike


Index: pfctl.c
===================================================================
RCS file: /cvs/src/sbin/pfctl/pfctl.c,v
retrieving revision 1.334
diff -u -p -u -r1.334 pfctl.c
--- pfctl.c     14 Jan 2016 12:05:51 -0000      1.334
+++ pfctl.c     2 Jun 2016 13:17:32 -0000
@@ -1507,7 +1507,7 @@ pfctl_rules(int dev, char *filename, int
 
        if (parse_config(filename, &pf) < 0) {
                if ((opts & PF_OPT_NOACTION) == 0)
-                       ERRX("Syntax error in config file: "
+                       ERRX("Error parsing config file: "
                            "pf rules not loaded");
                else
                        goto _error;

Reply via email to