On Fri, Jun 03, 2016 at 09:31:27PM -0400, Ted Unangst wrote:
> a few more here and there.
ok mglocker
> Index: ddb/db_examine.c
> ===================================================================
> RCS file: /cvs/src/sys/ddb/db_examine.c,v
> retrieving revision 1.21
> diff -u -p -r1.21 db_examine.c
> --- ddb/db_examine.c 19 Apr 2016 12:23:25 -0000 1.21
> +++ ddb/db_examine.c 4 Jun 2016 01:28:06 -0000
> @@ -277,7 +277,7 @@ db_strlcpy(char *dst, const char *src, s
> if (siz != 0)
> *d = '\0'; /* NUL-terminate dst */
> while (*s++)
> - ;
> + continue;
> }
>
> return(s - src - 1); /* count does not include NUL */
> Index: dev/hotplug.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/hotplug.c,v
> retrieving revision 1.15
> diff -u -p -r1.15 hotplug.c
> --- dev/hotplug.c 14 Mar 2015 03:38:46 -0000 1.15
> +++ dev/hotplug.c 4 Jun 2016 01:28:12 -0000
> @@ -134,7 +134,7 @@ hotplugclose(dev_t dev, int flag, int mo
> struct hotplug_event he;
>
> while (hotplug_get_event(&he) == 0)
> - ;
> + continue;
> opened = 0;
> return (0);
> }
> Index: dev/ipmi.c
> ===================================================================
> RCS file: /cvs/src/sys/dev/ipmi.c,v
> retrieving revision 1.96
> diff -u -p -r1.96 ipmi.c
> --- dev/ipmi.c 27 Mar 2016 12:45:47 -0000 1.96
> +++ dev/ipmi.c 4 Jun 2016 01:28:16 -0000
> @@ -640,7 +640,7 @@ kcs_wait(struct ipmi_softc *sc, u_int8_t
> if ((v & KCS_STATE_MASK) == KCS_ERROR_STATE) {
> bmc_write(sc, _KCS_COMMAND_REGISTER, KCS_GET_STATUS);
> while (bmc_read(sc, _KCS_STATUS_REGISTER) & KCS_IBF)
> - ;
> + continue;
> printf("%s: error code: %x\n", DEVNAME(sc),
> bmc_read(sc, _KCS_DATAIN_REGISTER));
> }
> Index: kern/kern_pledge.c
> ===================================================================
> RCS file: /cvs/src/sys/kern/kern_pledge.c,v
> retrieving revision 1.167
> diff -u -p -r1.167 kern_pledge.c
> --- kern/kern_pledge.c 27 May 2016 16:33:55 -0000 1.167
> +++ kern/kern_pledge.c 4 Jun 2016 01:28:21 -0000
> @@ -1601,7 +1601,7 @@ canonpath(const char *input, char *buf,
> p += 3;
> if (q != buf) /* "/../" at start of buf */
> while (*--q != '/')
> - ;
> + continue;
>
> } else {
> *q++ = *p++;
> Index: kern/kgdb_stub.c
> ===================================================================
> RCS file: /cvs/src/sys/kern/kgdb_stub.c,v
> retrieving revision 1.10
> diff -u -p -r1.10 kgdb_stub.c
> --- kern/kgdb_stub.c 7 Mar 2016 18:43:59 -0000 1.10
> +++ kern/kgdb_stub.c 4 Jun 2016 01:28:26 -0000
> @@ -240,7 +240,7 @@ kgdb_recv(u_char *bp, int maxlen)
> p = bp;
> csum = len = 0;
> while ((c = GETC()) != KGDB_START)
> - ;
> + continue;
>
> while ((c = GETC()) != KGDB_END && len < maxlen) {
> c &= 0x7f;
> Index: kern/vfs_bio.c
> ===================================================================
> RCS file: /cvs/src/sys/kern/vfs_bio.c,v
> retrieving revision 1.174
> diff -u -p -r1.174 vfs_bio.c
> --- kern/vfs_bio.c 17 Mar 2016 03:57:51 -0000 1.174
> +++ kern/vfs_bio.c 4 Jun 2016 01:28:32 -0000
> @@ -908,7 +908,7 @@ geteblk(int size)
> struct buf *bp;
>
> while ((bp = buf_get(NULL, 0, size)) == NULL)
> - ;
> + continue;
>
> return (bp);
> }
> @@ -1319,7 +1319,7 @@ bufcache_adjust(void)
> &cleancache[i].warmbufpages) ||
> chillbufs(&cleancache[i], &cleancache[i].hotqueue,
> &cleancache[i].hotbufpages))
> - ;
> + continue;
> }
> }
>
> Index: net/pf.c
> ===================================================================
> RCS file: /cvs/src/sys/net/pf.c,v
> retrieving revision 1.974
> diff -u -p -r1.974 pf.c
> --- net/pf.c 31 May 2016 07:35:36 -0000 1.974
> +++ net/pf.c 4 Jun 2016 01:28:57 -0000
> @@ -3867,7 +3867,7 @@ pf_tcp_track_full(struct pf_pdesc *pd, s
> if (dst->seqdiff && !src->seqdiff) {
> /* use random iss for the TCP server */
> while ((src->seqdiff = arc4random() - seq) == 0)
> - ;
> + continue;
> ack = ntohl(th->th_ack) - dst->seqdiff;
> pf_change_a(pd, &th->th_seq, htonl(seq + src->seqdiff));
> pf_change_a(pd, &th->th_ack, htonl(ack));
> Index: net/rtable.c
> ===================================================================
> RCS file: /cvs/src/sys/net/rtable.c,v
> retrieving revision 1.42
> diff -u -p -r1.42 rtable.c
> --- net/rtable.c 18 May 2016 03:46:03 -0000 1.42
> +++ net/rtable.c 4 Jun 2016 01:29:15 -0000
> @@ -468,7 +468,7 @@ rtable_walk(unsigned int rtableid, sa_fa
> return (EAFNOSUPPORT);
>
> while ((error = rn_walktree(rnh, f, arg)) == EAGAIN)
> - ; /* nothing */
> + continue;
>
> return (error);
> }
> @@ -862,7 +862,7 @@ rtable_walk(unsigned int rtableid, sa_fa
> rwc.rwc_rid = rtableid;
>
> while ((error = art_walk(ar, rtable_walk_helper, &rwc)) == EAGAIN)
> - ; /* nothing */
> + continue;
>
> return (error);
> }
>
