On Wed, Jun 22, 2016 at 05:08:24PM -0400, Ted Unangst wrote:
> Alexander Bluhm wrote:
> > +#ifndef SMALL_KERNEL
> > + if (mbp->msg_bufd > 0) {
> > + char buf[64];
>
> This is not so much code that I'm worried about it on small kernels. Rather,
> now you have the same problem where some kernels print correct information and
> some don't. I guess there's no syslog on ramdisk, so moot point? But I've been
> aggravated before by unexpected small kernel differences.
I have the #ifndef SMALL_KERNEL also in sendsyslog counting and I
wanted to be consistent. There is no syslogd on ramdisk, so the
feature is useless there. Besides code we also save the size of
the format strings.
But if install kernel size is not that important, I can remove both
ifdefs.
bluhm
