Hey all,

I noticed that mem.c for ARM could use a little style updating. Below
is my diff:

Index: sys/arch/arm/arm/mem.c
===================================================================
RCS file: /cvs/src/sys/arch/arm/arm/mem.c,v
retrieving revision 1.14
diff -u -r1.14 mem.c
--- sys/arch/arm/arm/mem.c    28 May 2015 20:53:05 -0000    1.14
+++ sys/arch/arm/arm/mem.c    28 Jul 2016 00:19:41 -0000
@@ -97,13 +97,8 @@
 extern int allowaperture;
 #endif

-
-/*ARGSUSED*/
 int
-mmopen(dev, flag, mode, p)
-    dev_t dev;
-    int flag, mode;
-    struct proc *p;
+mmopen(dev_t dev, int flag, int mode, struct proc *p)
 {
     switch (minor(dev)) {
         case 0:
@@ -129,12 +124,8 @@
     return (0);
 }

-/*ARGSUSED*/
 int
-mmclose(dev, flag, mode, p)
-    dev_t dev;
-    int flag, mode;
-    struct proc *p;
+mmclose(dev_t dev, int flag, int mode, struct proc *p)
 {
 #ifdef APERTURE
     if (minor(dev) == 4)
@@ -237,12 +228,9 @@
 }

 paddr_t
-mmmmap(dev, off, prot)
-    dev_t dev;
-    off_t off;
-    int prot;
+mmmmap(dev_t dev, off_t off, int prot)
 {
-    struct proc *p = curproc;    /* XXX */
+    struct proc *p = curproc;

     /*
      * /dev/mem is the only one that makes sense through this
@@ -262,7 +250,7 @@
         return -1;
     return off;
 }
-/*ARGSUSED*/
+
 int
 mmioctl(dev_t dev, u_long cmd, caddr_t data, int flags, struct proc *p)
 {


-- 
-Rob Tate

Reply via email to