Mon, 5 Sep 2016 07:24:17 -0400 (EDT) Anthony Coulter <[email protected]> > Some of the system scripts make inconsistent use of ksh-specific > features, specifically "print" and "[[" as efficient replacements for > "echo" and "[". This change makes the /etc/ksh.kshrc and all the rc > scripts use "print" and "[[" exclusively. > [...] > I corrected a comment at the top of /etc/rc; it said that "set +o sh" > turned Strict Bourne shell mode off. I'm pretty sure it's actually > turning strict mode on.
Hi Anthony, This appears to be one incorrect assumption. According the ksh(1) manual page "set command can be used to set (-) or clear (+) shell options", and "sh - Enable strict Bourne shell mode.." This makes the original comment for set +o sh correct, it clears the sh (strict Bourne shell mode) I also insist, you double checked your other proposals with the manuals as well. > My system still boots with these changes, and rcctl still appears to > work. I can't easily test all of the code paths in each of the rc > scripts. But the changes involved here are straightforward, and you > can validate this diff line-by-line. This also makes the proposals pretty unset, testing code paths is critical for start-up and other rc scripts that we must trust do what is expected.. The fact that one particular system still boots is not "good enough here". Kind regards, Anton
