> From: Jeremie Courreges-Anglas <[email protected]>
> Date: Mon, 26 Sep 2016 22:44:53 +0200
>
> Mark Kettenis <[email protected]> writes:
>
> >> From: Jeremie Courreges-Anglas <[email protected]>
> >> Date: Mon, 26 Sep 2016 22:19:54 +0200
> >>
> >> Mark Kettenis <[email protected]> writes:
> >>
> >> >> From: [email protected] (Jeremie Courreges-Anglas)
> >> >> Date: Mon, 26 Sep 2016 21:13:24 +0200
> >> >>
> >> >> AFAIK this is not a standard define, so it should be unconditionally
> >> >> reachable. mkr went fine.
> >> >>
> >> >> Thoughts?
> >> >
> >> > ok kettenis@, although perhaps it makes sense to move this #define a
> >> > bit further down the file into an existing __BSD_VISIBLE block.
> >>
> >> Yeah, but I didn't know where to move it. What about the following?
> >
> > That's probably the wrong block ;) SOCK_CLOEXEC is likely to end up in
> > the next POSIX standard, which means we'll have to shuffle around the
> > #if __BSD_VISIBLE.
> >
> > I'd put it right after the "struct splice" declaration, with a blank
> > line before and after.
>
> I thought about it too but then you don't get the ordering "typedefs,
> then defines, then structs" from the beginning of the file. OTOH
> there's no strict order after the struct linger definition. *shrug*
Yeah. Anyway, this version is definitely ok kettenis@
> Index: socket.h
> ===================================================================
> RCS file: /cvs/src/sys/sys/socket.h,v
> retrieving revision 1.91
> diff -u -p -p -u -r1.91 socket.h
> --- socket.h 12 Sep 2016 19:41:20 -0000 1.91
> +++ socket.h 26 Sep 2016 20:41:34 -0000
> @@ -57,9 +57,6 @@ typedef __sa_family_t sa_family_t; /* so
> * Definitions related to sockets: types, address families, options.
> */
>
> -/* Maximum number of alternate routing tables */
> -#define RT_TABLEID_MAX 255
> -
> /*
> * Types
> */
> @@ -142,6 +139,12 @@ struct splice {
> off_t sp_max; /* if set, maximum bytes to splice */
> struct timeval sp_idle; /* idle timeout */
> };
> +
> +/*
> + * Maximum number of alternate routing tables
> + */
> +#define RT_TABLEID_MAX 255
> +
> #endif /* __BSD_VISIBLE */
>
> /*
>
> --
> jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
>
