On Wed, Sep 28, 2016 at 01:34:52PM -0400, Okan Demirmen wrote: > Hi, > > Curious what the reaction might be if I removed the little geometry > window in the top-left corner for mouse/pointer based window resizes. > > We currently print the x/y dimensions only for mouse based actions; we > don't for kbd, nor do we do anything with mouse/kbd window moves (such > as printing the x/y coordinates, etc). So why have mouse-resize be > different? Thus, the below crudely removes it. > > One reason to remove it is for simplicity; this is the only place we > need to hold and carry around menuwin and a drawable. If we abused > menuwin/drawable in other locations but the actual menu'ing subsystem, > then ok. Alternatively, can create/destroy each time for a mouse-resize, > but likely not worth it, maybe it should stay... > > Thanks, > Okan > > Index: mousefunc.c > =================================================================== > RCS file: /home/open/cvs/xenocara/app/cwm/mousefunc.c,v > retrieving revision 1.107 > diff -u -p -r1.107 mousefunc.c > --- mousefunc.c 28 Sep 2016 17:06:33 -0000 1.107 > +++ mousefunc.c 28 Sep 2016 17:23:45 -0000 > @@ -89,7 +89,6 @@ mousefunc_client_resize(struct client_ct > cc->geom.h = ev.xmotion.y; > client_applysizehints(cc); > client_resize(cc, 1); > - mousefunc_sweep_draw(cc); > break; > case ButtonRelease: > client_resize(cc, 1); >
I typically use the mouse for window resizes, for xterms it's useful even to quickly see the dimensions even without resizing, ofc there are other ways to glean that info.. but if it's not too horrible, I'd like if it could stay. -Bryan.
