On Wed, Oct 05, 2016 at 04:48:55PM +0900, YASUOKA Masahiko wrote: > The diff add regress scripts for vxlan(4) and etherip(4). > > This will be my first commit to regress/. ok?
I does not run with an obj directory. root@ot1:.../etherip# make obj /usr/src/regress/sys/net/etherip/obj -> /usr/obj/regress/sys/net/etherip root@ot1:.../etherip# make ksh etherip_1.sh ksh: etherip_1.sh: No such file or directory *** Error 1 in . (Makefile:7 'etherip_1') FAILED *** Error 1 in target 'regress' (ignored) > +# rdomains > +RD1=11 > +RD2=12 > + > +# interface minor numbers > +IFNO1=11 > +IFNO2=12 I would prefer to see these variables in the Makefile. There you should tune the test resources. And a little longer names perhaps. > +if [ $VAL -eq 0 ]; then > + echo "Aborted. Disabled etherip by sysctl net.inet.etherip.allow" >&2 > + exit 255 > +fi Could you print SKIPPED here. My test framework checks for this to find tests that cannot run in the current environment. bluhm
