On Fri, Oct 07, 2016 at 11:26:58PM +0200, Martin Natano wrote:
> ks_tables.h is always considered out of date due to the forced rebuild
> of the makekeys util. This means it's also rebuilt during install. First
> as root during build, later by the BUILDUSER during release, which won't
> be able to rewrite it, because it's now owned by root. With this result:
> 
>       override rw-r--r--  root/wheel for ks_tables.h?
> 
> 
> One step closer towards noperm release builds for xenocara.
> 
> Ok?

Ok. Can you take care of pushing this upstreams, or should I ?

> 
> natano
> 
> 
> Index: src/Makefile.am
> ===================================================================
> RCS file: /cvs/xenocara/lib/libX11/src/Makefile.am,v
> retrieving revision 1.13
> diff -u -p -r1.13 Makefile.am
> --- src/Makefile.am   6 Apr 2015 20:57:59 -0000       1.13
> +++ src/Makefile.am   7 Oct 2016 21:15:08 -0000
> @@ -416,7 +416,5 @@ ks_tables.h: $(KEYSYMDEFS) $(top_builddi
>       $(top_builddir)/src/util/makekeys $(KEYSYMDEFS) > ks_tables_h
>       mv ks_tables_h $@
>  
> -$(top_builddir)/src/util/makekeys$(EXEEXT): force
> +$(top_builddir)/src/util/makekeys$(EXEEXT): 
> $(top_builddir)/src/util/makekeys.c
>       cd util && $(MAKE)
> -
> -force:
> Index: src/Makefile.in
> ===================================================================
> RCS file: /cvs/xenocara/lib/libX11/src/Makefile.in,v
> retrieving revision 1.22
> diff -u -p -r1.22 Makefile.in
> --- src/Makefile.in   6 Apr 2015 20:57:59 -0000       1.22
> +++ src/Makefile.in   7 Oct 2016 21:15:08 -0000
> @@ -1387,10 +1387,8 @@ ks_tables.h: $(KEYSYMDEFS) $(top_builddi
>       $(top_builddir)/src/util/makekeys $(KEYSYMDEFS) > ks_tables_h
>       mv ks_tables_h $@
>  
> -$(top_builddir)/src/util/makekeys$(EXEEXT): force
> +$(top_builddir)/src/util/makekeys$(EXEEXT): 
> $(top_builddir)/src/util/makekeys.c
>       cd util && $(MAKE)
> -
> -force:
>  
>  # Tell versions [3.59,3.63) of GNU make to not export all variables.
>  # Otherwise a system limit (for SysV at least) may be exceeded.

-- 
Matthieu Herrb

Attachment: signature.asc
Description: PGP signature

Reply via email to