On 10 October 2016 at 20:15, Claudio Jeker <cje...@diehard.n-r-g.com> wrote:
> So rn_refines() is a function from the deep underbelly of radix code.
> In my opinion if.c should not use this function especially now that we use
> art for routing table lookups. Instead I implemented a simple
> ifa_netmask_cmp() function that does what the code expects and compares
> the two netmasks. It is a bit more complictated than a simple memcmp()
> because netmasks can be encoded in a few ways (more or less padding
> bytes). Also the code assumes consecutive netmasks since that is the only
> thing we allow on interfaces and IP routes anyway.
>
> OK?

I think this is great.  I can't even tell if this does the same as rn_refines
cause it's nuts :-)  But if it does, then I'm all for your version (-:

Reply via email to