On Tue, Oct 11, 2016 at 10:31:38AM +0200, Ingo Schwarze wrote:
> Hi,
> Jan Stary wrote on Tue, Oct 11, 2016 at 07:53:23AM +0200:
> > cp(1) and rm(1) call setlocale(LC_ALL, "") but mv(1) does not.
> > Why do they do that, and why mv doesn't?
> That is useless and wasteful.
> I think it comes from a time when people still thought that doing
> more and more and more might bring you closer to perfection.
> Here is a simple diff to remove that junk
> and to properly return from main() while here.
> OK?


One quibble: some people decreed that return should have no parens.
That's fine with me, but I really dislike the inconsistency you create
with your diff: all other return calls in these files have them.  I'd
prefer to just do a plain s/exit/return or remove the parentheses
everywhere in those files if you absolutely must do that.

Reply via email to