On Sun, Oct 16, 2016 at 08:03:05PM -0600, Theo de Raadt wrote: > > On Sun, Oct 16, 2016 at 02:55:39PM -0700, Philip Guenther wrote: > > > > > > Instead of using errno as a hidden argument to vfatal(), make it an > > > _actual_ argument named 'code', ala the errc/warnc family, and rename it > > > to vfatalc() to match the pattern set. > > > > > > ok? > > > > > > Philip Guenther > > > > > > > Isn't this code used elsewhere too? > > benno is in the process of unifying all the log.c versions, as much > as possible. >
benno is working on a totally different variant of log.c that is found in the routing daemons. I talked with him at g2k16 about it and we'll eventually try to sync them all together once he is done with that, but he will first move all the daemon-/protocol-specific stuff out of the other log.c's. I unified my versions long ago, and there identical in at least: usr.sbin/httpd usr.sbin/ntpd usr.sbin/relayd usr.sbin/snmpd usr.sbin/switchd usr.sbin/vmd sbin/iked $ diff -Nup -I'\$OpenBSD' usr.sbin/vmd/log.c usr.sbin/ntpd/log.c I think Philip's code is OK and syncing it with the other daemons is as easy as copying vmd's updated version to all these directories and committing them at once. Reyk
