Hi Theo,

Theo Buehler wrote on Fri, Oct 14, 2016 at 09:09:34PM +0200:

> The patch reads fine to me and behaves well in some testing.
> It is ok tb@ as is.

Committed, thanks for checking.

> I wonder if for the sake of consistency it would be worth merging the
> 'b' and 'B' cases as well as the 'w' and 'W' cases the same way as you
> did merge the 'e' and 'E' cases below. The simplification is minimal,
> but it would read slightly better, I think.

Made sense to me, too.
Eight lines of code less and more similar to the other cases...

So i committed that too.


Reply via email to