>I found a few cases, where we should send a cache flush but don't. >Unfortunately, none of these cases explain the problem seen by >Jan and Darren. >The cases I have found are: >* When a R/W mount is updated to R/O. I will send patches for this in a >separate mail. >* When a R/W mount is unmounted but there is still another partition from the >same disk mounted. >* When sync(2) is called. Though I am not 100% sure if we really want > to do a cache flush for every sync. Thoughts?
What if somebody remounts from normal options (metadata: sync, data: async) to fully synced (metadata: sync, data: sync) Example: # mount | grep home /dev/sd1h on /home type ffs (local, noatime, nodev, nosuid) # /sbin/mount -u -o sync,rw,nodev,nosuid,noatime /home # mount | grep home /dev/sd1h on /home type ffs (local, noatime, nodev, nosuid, synchronous) Should this flush cache for this particular filesystem?