On Thu, Nov 03, 2016 at 11:21:52AM +0100, Martin Pieuchot wrote:
> Here's the next iteration of my diff introducing a rwlock to serialize
> the network input path with socket paths. Changes are:
This crashes with very similar symptoms to the ones I reported to
you when I tested the netlock patch. It panics as soon as I scan
the box with Nessus (running on another host).
(This is hand-typed, since the loop doesn't end (ddb.panic=0 since
the USB keyboard doesn't work in ddb).)
[...]
End of stack trace.
panic: rw_enter: socketlock locking against myself
Starting stack trace...
panic() at panic+0x10b
rw_enter() at rw_enter+0x1f8
if_downall() at if_downall+0x26
boot() at boot+0xe4
reboot() at reboot+0x30
panic() at panic+0x106
rw_enter() at rw_enter+0x1f8
if_downall() at if_downall+0x26
boot() at boot+0xe4
reboot() at reboot+0x30
panic() at panic+0x106
rw_enter() at rw_enter+0x1f8
if_downall() at if_downall+0x26
boot() at boot+0xe4
reboot() at reboot+0x30
panic() at panic+0x106
rw_enter() at rw_enter+0x1f8
if_downall() at if_downall+0x26
boot() at boot+0xe4
reboot() at reboot+0x30
panic() at panic+0x106
[...]
panic() at panic+0x106
rw_enter() at rw_enter+0x1f8
soclose() at soclose+0x1e
soo_close() at soo_close+0x1c
fdrop() at fdrop+0x2c
closef() at closef+0xcb
doaccept() at doaccept+0x416
syscall() at syscall+0x27b
--- syscall (number 30) ---
end of kernel
end trace frame: 0x4, count: 154
0x242f17f09aa:
End of stack trace.
panic: rw_enter: socketlock locking against myself
[...]
dmesg:
OpenBSD 6.0-current (GENERIC.MP) #3: Thu Nov 3 11:40:49 CET 2016
[email protected]:/usr/src/sys/arch/amd64/compile/GENERIC.MP
real mem = 4272250880 (4074MB)
avail mem = 4138213376 (3946MB)
mpath0 at root
scsibus0 at mpath0: 256 targets
mainbus0 at root
bios0 at mainbus0: SMBIOS rev. 2.4 @ 0xbfec5000 (44 entries)
bios0: vendor Apple Inc. version "IM81.88Z.00C1.B00.0802091538" date 02/09/08
bios0: Apple Inc. iMac8,1
acpi0 at bios0: rev 2
acpi0: sleep states S0 S3 S4 S5
acpi0: tables DSDT FACP HPET APIC MCFG ASF! SBST ECDT SSDT SSDT SSDT SSDT
acpi0: wakeup devices FRWR(S3) ARPT(S3) GIGE(S3) UHC1(S3) UHC2(S3) UHC3(S3)
UHC4(S3) UHC5(S3) EHC1(S3) EHC2(S3) EC__(S3)
acpitimer0 at acpi0: 3579545 Hz, 24 bits
acpihpet0 at acpi0: 14318179 Hz
acpimadt0 at acpi0 addr 0xfee00000: PC-AT compat
cpu0 at mainbus0: apid 0 (boot processor)
cpu0: Intel(R) Core(TM)2 Duo CPU E8135 @ 2.40GHz, 2392.61 MHz
cpu0:
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,DTES64,MWAIT,DS-CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,SSE4.1,NXE,LONG,LAHF,PERF,SENSOR
cpu0: 6MB 64b/line 16-way L2 cache
cpu0: smt 0, core 0, package 0
mtrr: Pentium Pro MTRR support, 8 var ranges, 88 fixed ranges
cpu0: apic clock running at 265MHz
cpu0: mwait min=64, max=64, C-substates=0.2.2.2.2, IBE
cpu1 at mainbus0: apid 1 (application processor)
cpu1: Intel(R) Core(TM)2 Duo CPU E8135 @ 2.40GHz, 2392.26 MHz
cpu1:
FPU,VME,DE,PSE,TSC,MSR,PAE,MCE,CX8,APIC,SEP,MTRR,PGE,MCA,CMOV,PAT,PSE36,CFLUSH,DS,ACPI,MMX,FXSR,SSE,SSE2,SS,HTT,TM,PBE,SSE3,DTES64,MWAIT,DS-CPL,VMX,EST,TM2,SSSE3,CX16,xTPR,PDCM,SSE4.1,NXE,LONG,LAHF,PERF,SENSOR
cpu1: 6MB 64b/line 16-way L2 cache
cpu1: smt 0, core 1, package 0
ioapic0 at mainbus0: apid 1 pa 0xfec00000, version 20, 24 pins
acpimcfg0 at acpi0 addr 0xf0000000, bus 0-255
acpiec0 at acpi0
acpiprt0 at acpi0: bus 0 (PCI0)
acpiprt1 at acpi0: bus 1 (PEGP)
acpiprt2 at acpi0: bus 3 (RP04)
acpiprt3 at acpi0: bus 4 (RP05)
acpiprt4 at acpi0: bus 5 (RP06)
acpicpu0 at acpi0: !C3(100@57 mwait.3@0x31), !C2(500@1 mwait@0x10), C1(1000@1
mwait), PSS
acpicpu1 at acpi0: !C3(100@57 mwait.3@0x31), !C2(500@1 mwait@0x10), C1(1000@1
mwait), PSS
"APP0002" at acpi0 not configured
acpibtn0 at acpi0: PWRB
acpibtn1 at acpi0: SLPB
"APP0001" at acpi0 not configured
acpivideo0 at acpi0: GFX0
cpu0: Enhanced SpeedStep 2392 MHz: speeds: 2400, 2133, 1867, 1600, 800 MHz
pci0 at mainbus0 bus 0
pchb0 at pci0 dev 0 function 0 "Intel GM965 Host" rev 0x03
ppb0 at pci0 dev 1 function 0 "Intel GM965 PCIE" rev 0x03: msi
pci1 at ppb0 bus 1
radeondrm0 at pci1 dev 0 function 0 "ATI Mobility Radeon HD 2400 XT" rev 0x00
drm0 at radeondrm0
radeondrm0: msi
uhci0 at pci0 dev 26 function 0 "Intel 82801H USB" rev 0x04: apic 1 int 20
uhci1 at pci0 dev 26 function 1 "Intel 82801H USB" rev 0x04: apic 1 int 16
ehci0 at pci0 dev 26 function 7 "Intel 82801H USB" rev 0x04: apic 1 int 21
usb0 at ehci0: USB revision 2.0
uhub0 at usb0 configuration 1 interface 0 "Intel EHCI root hub" rev 2.00/1.00
addr 1
azalia0 at pci0 dev 27 function 0 "Intel 82801H HD Audio" rev 0x04: msi
azalia0: codecs: Realtek ALC885
audio0 at azalia0
ppb1 at pci0 dev 28 function 0 "Intel 82801H PCIE" rev 0x04: msi
pci2 at ppb1 bus 2
ppb2 at pci0 dev 28 function 3 "Intel 82801H PCIE" rev 0x04: msi
pci3 at ppb2 bus 3
"AT&T/Lucent FW643 1394" rev 0x06 at pci3 dev 0 function 0 not configured
ppb3 at pci0 dev 28 function 4 "Intel 82801H PCIE" rev 0x04: msi
pci4 at ppb3 bus 4
"Broadcom BCM4321" rev 0x05 at pci4 dev 0 function 0 not configured
ppb4 at pci0 dev 28 function 5 "Intel 82801H PCIE" rev 0x04: msi
pci5 at ppb4 bus 5
mskc0 at pci5 dev 0 function 0 "Marvell Yukon 88E8058" rev 0x13, Yukon-2 EC
Ultra rev. B0 (0x3): apic 1 int 17
msk0 at mskc0 port A: address 00:23:32:92:eb:2e
eephy0 at msk0 phy 0: 88E1149 Gigabit PHY, rev. 1
uhci2 at pci0 dev 29 function 0 "Intel 82801H USB" rev 0x04: apic 1 int 16
uhci3 at pci0 dev 29 function 1 "Intel 82801H USB" rev 0x04: apic 1 int 18
uhci4 at pci0 dev 29 function 2 "Intel 82801H USB" rev 0x04: apic 1 int 21
ehci1 at pci0 dev 29 function 7 "Intel 82801H USB" rev 0x04: apic 1 int 20
usb1 at ehci1: USB revision 2.0
uhub1 at usb1 configuration 1 interface 0 "Intel EHCI root hub" rev 2.00/1.00
addr 1
ppb5 at pci0 dev 30 function 0 "Intel 82801BAM Hub-to-PCI" rev 0xf4
pci6 at ppb5 bus 6
pcib0 at pci0 dev 31 function 0 "Intel 82801HBM LPC" rev 0x04
pciide0 at pci0 dev 31 function 1 "Intel 82801HBM IDE" rev 0x04: DMA, channel 0
configured to native-PCI, channel 1 configured to native-PCI
pciide0: using apic 1 int 21 for native-PCI interrupt
atapiscsi0 at pciide0 channel 0 drive 0
scsibus1 at atapiscsi0: 2 targets
cd0 at scsibus1 targ 0 lun 0: <OPTIARC, DVD RW AD-5630A, 1AHN> ATAPI 5/cdrom
removable
cd0(pciide0:0:0): using PIO mode 4, Ultra-DMA mode 2
pciide0: channel 1 disabled (no drives)
ahci0 at pci0 dev 31 function 2 "Intel 82801HBM AHCI" rev 0x04: msi, AHCI 1.1
ahci0: port 0: 3.0Gb/s
scsibus2 at ahci0: 32 targets
sd0 at scsibus2 targ 0 lun 0: <ATA, SanDisk SDSSDA12, Z220> SCSI3 0/direct
fixed naa.5001b444a4eacec8
sd0: 114473MB, 512 bytes/sector, 234441648 sectors, thin
ichiic0 at pci0 dev 31 function 3 "Intel 82801H SMBus" rev 0x04: apic 1 int 20
iic0 at ichiic0
spdmem0 at iic0 addr 0x50: 2GB DDR2 SDRAM non-parity PC2-6400CL6 SO-DIMM
spdmem1 at iic0 addr 0x52: 2GB DDR2 SDRAM non-parity PC2-6400CL6 SO-DIMM
usb2 at uhci0: USB revision 1.0
uhub2 at usb2 configuration 1 interface 0 "Intel UHCI root hub" rev 1.00/1.00
addr 1
usb3 at uhci1: USB revision 1.0
uhub3 at usb3 configuration 1 interface 0 "Intel UHCI root hub" rev 1.00/1.00
addr 1
usb4 at uhci2: USB revision 1.0
uhub4 at usb4 configuration 1 interface 0 "Intel UHCI root hub" rev 1.00/1.00
addr 1
usb5 at uhci3: USB revision 1.0
uhub5 at usb5 configuration 1 interface 0 "Intel UHCI root hub" rev 1.00/1.00
addr 1
usb6 at uhci4: USB revision 1.0
uhub6 at usb6 configuration 1 interface 0 "Intel UHCI root hub" rev 1.00/1.00
addr 1
isa0 at pcib0
isadma0 at isa0
pcppi0 at isa0 port 0x61
spkr0 at pcppi0
asmc0 at isa0 port 0x300/32: rev 1.29f529, 224 keys
vmm0 at mainbus0: VMX
efifb at mainbus0 not configured
urtw0 at uhub0 port 2 configuration 1 interface 0 "Realtek RTL8187" rev
2.00/1.00 addr 2
urtw0: RTL8187 rev 0x04, RFv2, address 00:e0:4c:91:d3:e4
uhub7 at uhub0 port 4 configuration 1 interface 0 "Apple, Inc. Keyboard Hub"
rev 2.00/96.15 addr 3
uhidev0 at uhub7 port 2 configuration 1 interface 0 "Apple, Inc Apple Keyboard"
rev 2.00/0.69 addr 4
uhidev0: iclass 3/1
ukbd0 at uhidev0: 8 variable keys, 5 key codes, country code 13
wskbd0 at ukbd0 mux 1
uhidev1 at uhub7 port 2 configuration 1 interface 1 "Apple, Inc Apple Keyboard"
rev 2.00/0.69 addr 4
uhidev1: iclass 3/0
uhid0 at uhidev1: input=1, output=0, feature=0
uhidev2 at uhub7 port 3 configuration 1 interface 0 "Logitech USB Receiver" rev
2.00/12.01 addr 5
uhidev2: iclass 3/1
ukbd1 at uhidev2: 8 variable keys, 6 key codes
wskbd1 at ukbd1 mux 1
uhidev3 at uhub7 port 3 configuration 1 interface 1 "Logitech USB Receiver" rev
2.00/12.01 addr 5
uhidev3: iclass 3/1, 8 report ids
ums0 at uhidev3 reportid 2: 16 buttons, Z and W dir
wsmouse0 at ums0 mux 0
uhid1 at uhidev3 reportid 3: input=4, output=0, feature=0
uhid2 at uhidev3 reportid 4: input=1, output=0, feature=0
uhid3 at uhidev3 reportid 8: input=1, output=0, feature=0
uhidev4 at uhub7 port 3 configuration 1 interface 2 "Logitech USB Receiver" rev
2.00/12.01 addr 5
uhidev4: iclass 3/0, 33 report ids
uhid4 at uhidev4 reportid 16: input=6, output=6, feature=0
uhid5 at uhidev4 reportid 17: input=19, output=19, feature=0
uhid6 at uhidev4 reportid 32: input=14, output=14, feature=0
uhid7 at uhidev4 reportid 33: input=31, output=31, feature=0
uvideo0 at uhub1 port 4 configuration 1 interface 0 "Apple Inc. Built-in
iSight" rev 2.00/1.60 addr 2
video0 at uvideo0
ugen0 at uhub1 port 4 configuration 1 "Apple Inc. Built-in iSight" rev
2.00/1.60 addr 2
uhub8 at uhub2 port 1 configuration 1 interface 0 "Apple Inc. BRCM2046 Hub" rev
2.00/1.00 addr 2
ugen1 at uhub8 port 1 "Apple Inc. Bluetooth USB Host Controller" rev 2.00/2.08
addr 3
uhidev5 at uhub8 port 2 configuration 1 interface 0 "Apple Computer product
0x820a" rev 2.00/1.00 addr 4
uhidev5: iclass 3/1, 1 report id
ukbd2 at uhidev5 reportid 1: 8 variable keys, 6 key codes
wskbd2 at ukbd2 mux 1
uhidev6 at uhub8 port 3 configuration 1 interface 0 "Apple Computer product
0x820b" rev 2.00/1.00 addr 5
uhidev6: iclass 3/1, 2 report ids
ums1 at uhidev6 reportid 2: 3 buttons
wsmouse1 at ums1 mux 0
uhidev7 at uhub6 port 1 configuration 1 interface 0 "Apple Computer, Inc. IR
Receiver" rev 2.00/0.16 addr 2
uhidev7: iclass 3/0, 38 report ids
uhid8 at uhidev7 reportid 36: input=4, output=0, feature=0
uhid9 at uhidev7 reportid 37: input=4, output=0, feature=0
uhid10 at uhidev7 reportid 38: input=4, output=0, feature=0
vscsi0 at root
scsibus3 at vscsi0: 256 targets
softraid0 at root
scsibus4 at softraid0: 256 targets
root on sd0a (dad57c1aed5a4d01.a) swap on sd0b dump on sd0b
error: [drm:pid0:radeon_read_platform_bios] *ERROR* bios size zero or checksum
mismatch
radeondrm0: 1680x1050
wsdisplay0 at radeondrm0 mux 1: console (std, vt100 emulation)
wskbd0: connecting to wsdisplay0
wskbd1: connecting to wsdisplay0
wskbd2: connecting to wsdisplay0
wsdisplay0: screen 1-5 added (std, vt100 emulation)
