On Tue, Nov 08, 2016 at 11:58:12AM -0800, Philip Guenther wrote: > On Tue, Nov 8, 2016 at 11:49 AM, Theo Buehler <[email protected]> wrote: > > One more: all these symlinks get permissions dependent on the umask > > during make build, so set them explicitly to 755. I don't think there's > > enough of them to warrant creating a SYMLINKMODE in bsd.own.mk. > > Meh. symlink mode has *no* effect beyond showing up in lstat() > output, so I don't think we should clutter the }Makefiles with this. > If you want exactly reproducible builds, including the ignored symlink > bits, then set your umask consistently.
I thought there might be objections because of that, that's why I grouped them all together... My motivation was twofold: - I don't think the umask of the build machine should affect the filesets it generates - I thought it would be easier to audit if each chown call is paired with a chmod call. Since it's just in those 4 files (there are a few more in etc/Makefile), I thought the clutter might be bearable. Anyway, I don't feel strongly about it and don't insist.
