On 12/12/16(Mon) 16:35, Mike Belopuhov wrote: > On Mon, Dec 12, 2016 at 16:15 +0100, Martin Pieuchot wrote: > > [...] > > Why pass the socket to add_vif() when you only need the rdomain? > > > > It makes add_vif take same arguments as some other functions called > from ip_mrouter_set in that switch statement (like ip_mrouter_init).
Makes sense. > > I'm also confused, if you need a rdomain shouldn't you be using > > rtable_l2()? > > > > He has tested with rdomains, but in this particular case you're doing > setsockopt, you don't know what rtable your socket is associated with > and you're just passing the value along. But besides, ifa_ifwithaddr > will call the rtable_l2 itself (which makes sense I guess as we have > to look up within the whole rdomain). I just got confused by the description, it's indeed not rdomain related. ok mpi@
