On 2016/12/18 14:44, Jasper Lievisse Adriaanse wrote:
> Hi,
>
> This diff widens the IF column in 'systat rules' by one character. Reason for
> this is that otherwise vether interfaces get cut off and lose their index.
> vether interfaces are common enough I think to warrant this widening. However
> this might lead to confusion if there are interfaces with two digits. If
> that's common I can go +2 in this change.
>
> OK for +1 or +2?
I have a couple of vether devices with 2 digits, but more importantly
quite a few vlan interfaces with 3 digits (and one or two with 4, mostly
where a provider has given a high tag id; I try to use the id in the
interface name). So I'd rather +2, or perhaps even +3 (9 total) to
allow for an "on !vlan1234" rule.
> Index: pftop.c
> ===================================================================
> RCS file: /cvs/src/usr.bin/systat/pftop.c,v
> retrieving revision 1.34
> diff -u -p -r1.34 pftop.c
> --- pftop.c 13 Apr 2016 05:25:45 -0000 1.34
> +++ pftop.c 18 Dec 2016 13:39:51 -0000
> @@ -140,7 +140,7 @@ field_def fields[] = {
> {"LOG", 1, 3, 2, FLD_ALIGN_LEFT, -1, 0, 0, 0},
> {"QUICK", 1, 1, 1, FLD_ALIGN_LEFT, -1, 0, 0, 0},
> {"KS", 1, 1, 1, FLD_ALIGN_LEFT, -1, 0, 0, 0},
> - {"IF", 4, 6, 1, FLD_ALIGN_LEFT, -1, 0, 0, 0},
> + {"IF", 4, 7, 1, FLD_ALIGN_LEFT, -1, 0, 0, 0},
> {"INFO", 40, 80, 1, FLD_ALIGN_LEFT, -1, 0, 0, 0},
> {"MAX", 3, 5, 2, FLD_ALIGN_RIGHT, -1, 0, 0},
> {"RATE", 5, 8, 1, FLD_ALIGN_RIGHT, -1, 0, 0, 0},
>
> --
> jasper
>
