On 20 December 2016 at 16:03, Patrick Wildt <patr...@blueri.se> wrote: > Hi, > > I just realized that bioctl can print its uninitialized memory. The > function bio_status() prints information from a struct basically after > each ioctl(). The BIOCLOCATE ioctl() though never sets this in the > struct. Thus each BIOCLOCATE ioctl() keeps the struct in the state > as it has been before. > > There are two cases where bioctl calls bio_status() after a BIOCLOCATE. > In one case the struct is zeroed before, in the other it isn't. > > I propose removing the prints after the BIOLOCATEs to not make anyone > believe there should actually be a status print. Additionally I'd like > to add a memset in the one case where there's none. > > ok? > > Patrick
Looks good to me. OK mikeb
