On Fri, Dec 23, 2016 at 09:41:07PM +0100, Mark Kettenis wrote:
> Here clang complains about an implicit enum conversion.
>
> Diff below fixes this by simply using the appropriate ieee80211 enum
> in the HAL_OPMODE typedef and defining HAL_M_XXX as aliases for
> IEEE80211_M_XXX. This matches what we already do for HAL_LED_STATE.
>
> ok?
>
ok stsp@
> Index: dev/ic/ar5xxx.h
> ===================================================================
> RCS file: /cvs/src/sys/dev/ic/ar5xxx.h,v
> retrieving revision 1.57
> diff -u -p -r1.57 ar5xxx.h
> --- dev/ic/ar5xxx.h 18 Dec 2016 14:34:20 -0000 1.57
> +++ dev/ic/ar5xxx.h 23 Dec 2016 20:35:53 -0000
> @@ -100,12 +100,12 @@ typedef enum {
> HAL_ANT_MAX = 3,
> } HAL_ANT_SETTING;
>
> -typedef enum {
> - HAL_M_STA = 1,
> - HAL_M_IBSS = 0,
> - HAL_M_HOSTAP = 6,
> - HAL_M_MONITOR = 8,
> -} HAL_OPMODE;
> +typedef enum ieee80211_opmode HAL_OPMODE;
> +
> +#define HAL_M_STA IEEE80211_M_STA
> +#define HAL_M_IBSS IEEE80211_M_IBSS
> +#define HAL_M_HOSTAP IEEE80211_M_HOSTAP
> +#define HAL_M_MONITOR IEEE80211_M_MONITOR
>
> typedef int HAL_STATUS;
>
>
