On 3 January 2017 at 12:06, Reyk Floeter <r...@openbsd.org> wrote: > On Tue, Jan 03, 2017 at 11:42:21AM +0100, Martin Pieuchot wrote: >> On 02/01/17(Mon) 21:51, Mike Belopuhov wrote: >> > I got to test the diff and I had to make another adjustment: >> > vxlan_if_change is setup as a detach hook, however dohooks is >> > called very early in if_detach before we remove IP addresses >> > from the interface. It makes vxlan_config find these IP >> > addresses just fine and re-add its own detach hook again. >> >> Why not fix vxlan_if_change()? >> >> > This >> > repeats ad infinitum hogging the machine. I couldn't think of >> > anything better than deferring an operation via a task. Seems >> > to do the trick. >> >> That's ugly. Why would you re-add anything in a detach hook? This >> is obviously broken. >> > > It is used for the multicast address (only) and it made sense when the > source address wasn't mandatory, eg. 0.0.0.0 -> 239.1.1.100 would find > the next interface that points to the group after detaching the > current one. > > The source is mandatory now, so the diff below should work as well. > > Reyk >
Thanks, this looks good, OK mikeb
