> Date: Sat, 7 Jan 2017 12:20:06 +0000 > From: Visa Hankala <v...@openbsd.org> > > On Sat, Jan 07, 2017 at 12:23:31AM +0100, Frederic Cambus wrote: > > Hi tech@, > > > > Here is a diff to use proper RGB values for the ANSI color palette in > > rasops(9). > > > > Comments? OK? > > I prefer the old palette because its contrast is higher.
Right. I don't see why we should change this. On top of that, on sparc64 the colors are carefully matched to what OpenFirmware uses for the console. So changing white will make things look ugly. > > Index: sys/dev/rasops/rasops.c > > =================================================================== > > RCS file: /cvs/src/sys/dev/rasops/rasops.c,v > > retrieving revision 1.44 > > diff -u -p -r1.44 rasops.c > > --- sys/dev/rasops/rasops.c 15 Dec 2016 19:18:41 -0000 1.44 > > +++ sys/dev/rasops/rasops.c 6 Jan 2017 22:11:02 -0000 > > @@ -48,21 +48,21 @@ > > /* ANSI colormap (R,G,B) */ > > > > #define NORMAL_BLACK 0x000000 > > -#define NORMAL_RED 0x7f0000 > > -#define NORMAL_GREEN 0x007f00 > > -#define NORMAL_BROWN 0x7f7f00 > > -#define NORMAL_BLUE 0x00007f > > -#define NORMAL_MAGENTA 0x7f007f > > -#define NORMAL_CYAN 0x007f7f > > -#define NORMAL_WHITE 0xc7c7c7 /* XXX too dim? */ > > +#define NORMAL_RED 0xaa0000 > > +#define NORMAL_GREEN 0x00aa00 > > +#define NORMAL_BROWN 0xaa5500 > > +#define NORMAL_BLUE 0x0000aa > > +#define NORMAL_MAGENTA 0xaa00aa > > +#define NORMAL_CYAN 0x00aaaa > > +#define NORMAL_WHITE 0xaaaaaa > > > > -#define HILITE_BLACK 0x7f7f7f > > -#define HILITE_RED 0xff0000 > > -#define HILITE_GREEN 0x00ff00 > > -#define HILITE_BROWN 0xffff00 > > -#define HILITE_BLUE 0x0000ff > > -#define HILITE_MAGENTA 0xff00ff > > -#define HILITE_CYAN 0x00ffff > > +#define HILITE_BLACK 0x555555 > > +#define HILITE_RED 0xff5555 > > +#define HILITE_GREEN 0x55ff55 > > +#define HILITE_BROWN 0xffff55 > > +#define HILITE_BLUE 0x5555ff > > +#define HILITE_MAGENTA 0xff55ff > > +#define HILITE_CYAN 0x55ffff > > #define HILITE_WHITE 0xffffff > > > > const u_char rasops_cmap[256 * 3] = { > > > >