Hi,

when fixing my virtio config breakage, I found the following comment
in sys/conf/files, followed by a few bus defines:

---snip---
# Attributes which machine-independent bus support can be attached to.
# These should be defined here, because some of these busses can have
# devices which provide these attributes, and we'd like to avoid hairy
# ordering constraints on inclusion of the busses' "files" files.
---snap---

I think we should follow this rule for pvbus(4) as well.
diff below tested with config GENERIC on all archs.

OK?

Reyk

Index: sys/conf/files
===================================================================
RCS file: /cvs/src/sys/conf/files,v
retrieving revision 1.638
diff -u -p -u -p -r1.638 files
--- sys/conf/files      22 Jan 2017 20:08:10 -0000      1.638
+++ sys/conf/files      22 Jan 2017 20:11:11 -0000
@@ -444,6 +444,7 @@ define      sdmmcbus {}                     # SD/MMC 
attachment
 define btbus {}                        # Bluetooth host controller
 define agpbus {}                       # AGP bridge
 device virtio {}                       # VirtIO
+define pvbus {}                        # paravirtual device tree
 
 # UHCI USB controller
 device uhci: usbus
Index: sys/dev/pv/files.pv
===================================================================
RCS file: /cvs/src/sys/dev/pv/files.pv,v
retrieving revision 1.12
diff -u -p -u -p -r1.12 files.pv
--- sys/dev/pv/files.pv 22 Jan 2017 20:08:10 -0000      1.12
+++ sys/dev/pv/files.pv 22 Jan 2017 20:11:11 -0000
@@ -3,7 +3,6 @@
 # Config file and device description for paravirtual devices.
 # Included by ports that need it.
 
-define pvbus {}
 device pvbus
 attach pvbus at mainbus
 file   dev/pv/pvbus.c                  pvbus   needs-flag

Reply via email to