On 24/01/17(Tue) 14:43, Richard Procter wrote: > Hi, > > PF implements six distinct TCP option parsing loops. This patch converts > these to one inline function in pfvar_priv.h, normalises their semantics, > and strips ~100 lines.
I like it. > I've laid out the existing semantics below. The new loop implements the > timestamp parser's semantics of "(s-b) (v-3) (t-a) (t-b)". As a result, > > - MSS and WSCALE parsers are stricter about candidate option len. > - MSS normalization is more tolerant of malformed option lists. > > These changes were immaterial to the live traffic I've examined (thanks to > Richard Cziva for help in gathering the data). Is it possible to build regression tests for that?
