On Wed, Jan 25, 2017 at 09:53:34AM +0100, Sebastian Benoit wrote: > this removes the pf_consistency_lock and protects the users with NET_LOCK() > > I ran into a crash when using pfctl -k, and mpi suggested this change (and > likes the diff). > > pf hackers: ok?
OK bluhm@ > +pf_purge_expired_src_nodes(void) ... > if (cur->states == 0 && cur->expire <= time_uptime) { > - if (! locked) { > - rw_enter_write(&pf_consistency_lock); > - next = RB_NEXT(pf_src_tree, > - &tree_src_tracking, cur); > - locked = 1; > - } > + next = RB_NEXT(pf_src_tree, > + &tree_src_tracking, cur); This statement fits in a single line now.