Jonathan Matthew <[email protected]> writes: > This is much like the other per cpu counter conversions, except the counter > enum has gaps in it to match the arrays in struct icmpstat.
I missed this mail and implemented basically the same diff. :-/ So your diff looks fine to me, the difference that I could spot are: - icmp_sysctl_icmpstat before icmp_sysctl to remove the need for a decl - I removed the 'if (newp != NULL)' in the ICMPCTL_STATS case, sysctl_rdstruct shoudl take care of that - declare icmpcounters before the definition of icmpstat_inc in icmp_var.h, that removes the need for the extern decl within said function - s/KASSERT/CTASSERT/ in icmp_sysctl_icmpstat I'd say that CTASSERT is a real improvement, the rest is cosmetic. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
