On Fri, Feb 10, 2017 at 08:56:13AM -0600, joshua stein wrote: > On Thu, 09 Feb 2017 at 18:30:59 -0600, joshua stein wrote: > > Without this, my MacBook Air won't suspend properly (hangs calling > > _PTS) and a similar change in Linux from 2014 (commit > > 7bc5a2bad0b8d9d1ac9f7b8b33150e4ddf197334) notes that upon resume, > > the Thunderbolt ports won't be powered up without pretending to be > > Darwin. > > One regression that this introduces is that acpibat no longer > attaches, because _STA on the PNP0C0A device returns 0 when the OS > is Darwin, expecting it to instead attach to the ACPI Smart Battery > Subsystem device (ACPI0002). > > I'm looking into what it will take to write an ACPI smart battery > driver. >
The original diff is ok, but I think if you commit it, you'll hear screams from people complaining their batteries aren't recognized anymore. I'd probably wait until you have the smart battery driver done, then commit the diff. But I don't have any of this hardware so either way it's not going to affect me. Use your best judgement I guess. -ml
