David Hill <[email protected]> writes:
> Hello -
>
> This moves the 'struct protosw' declarations to use C99 initializers.
> Requested by mpi@
ok jca@
Just one nit,
[...]
> Index: net/rtsock.c
> ===================================================================
> RCS file: /cvs/src/sys/net/rtsock.c,v
> retrieving revision 1.222
> diff -u -p -r1.222 rtsock.c
> --- net/rtsock.c 1 Feb 2017 20:59:47 -0000 1.222
> +++ net/rtsock.c 19 Feb 2017 02:15:00 -0000
> @@ -1654,13 +1654,23 @@ sysctl_rtable_rtstat(void *oldp, size_t
> extern struct domain routedomain; /* or at least forward
> */
>
> struct protosw routesw[] = {
> -{ SOCK_RAW, &routedomain, 0, PR_ATOMIC|PR_ADDR|PR_WANTRCVD,
> - 0, route_output, 0, route_ctloutput,
> - route_usrreq,
> - raw_init, 0, 0, 0,
> - sysctl_rtable,
> +{
> + .pr_type = SOCK_RAW,
> + .pr_domain = &routedomain,
> + .pr_protocol = 0,
> + .pr_flags = PR_ATOMIC|PR_ADDR|PR_WANTRCVD,
> + .pr_input = NULL,
> + .pr_output = route_output,
> + .pr_ctlinput = NULL,
> + .pr_ctloutput = route_ctloutput,
> + .pr_usrreq = route_usrreq,
> + .pr_init = raw_init,
> + .pr_fasttimo = NULL,
> + .pr_slowtimo = NULL,
> + .pr_drain = NULL,
> + .pr_sysctl = sysctl_rtable
> }
> -};
> +};
You're adding a trailing tab here.
--
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
