Florian Obser <[email protected]> writes: > On Sat, Feb 18, 2017 at 06:06:01PM +0100, Jeremie Courreges-Anglas wrote: >> >> This one is a bit weird, the driver doesn't just increment the stats but >> also uses them at runtime, hence the additional helper functions. > > I'm wondering if we should just drop the reading. > We have two cases, the init case and the packet sending case. > First the sending case: > Isn't this always true? > if (pflowstats.pflow_flows == sc->sc_gcounter) > If yes we can just skip that and do the inc. > > The init case tries to preserve the flow counter betwen ifdown/ifup > Maybe we should just init the global counter to 0, like on reboot. > Benno?
revision 1.9 date: 2009/01/03 21:47:32; author: gollo; state: Exp; lines: +11 -7; sync flow sequence ids on all used pflow interfaces. Right now I can't tell whether this change makes little or a lot of sense, so I'd better not touch this. :) In any case, the use of the counters API in this first diff doesn't make sense, please disregard it. -- jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF DDCC 0DFA 74AE 1524 E7EE
