On Fri, Mar 10, 2017 at 07:27:57PM -0800, Philip Guenther wrote:
> 
> With the addition of the SHA512_256 family, there are five families, not 
> four.
> 
> ok?
> 

i'm ok with this, but it's one of those situations where us correctly
documenting the number of things in existence doesn;t gain us anything
(it doesn't help the reader) but we put ourselves at risk of being
caught out when the number changes.

i'd say, remove the sentence!

see inline for another thought:

> Index: /usr/src/lib/libc/hash/sha2.3
> ===================================================================
> RCS file: /data/src/openbsd/src/lib/libc/hash/sha2.3,v
> retrieving revision 1.26
> diff -u -p -r1.26 sha2.3
> --- /usr/src/lib/libc/hash/sha2.3     4 Sep 2016 09:28:12 -0000       1.26
> +++ /usr/src/lib/libc/hash/sha2.3     11 Mar 2017 03:23:05 -0000
> @@ -168,11 +168,12 @@ The SHA2 functions implement the NIST Se
>  FIPS PUB 180-2.
>  The SHA2 functions are used to generate a condensed representation of a
>  message called a message digest, suitable for use as a digital signature.
> -There are four families of functions, with names corresponding to
> +There are five families of functions, with names corresponding to
>  the number of bits in the resulting message digest.
>  The SHA-224 and SHA-256 functions are limited to processing a message of less
>  than 2^64 bits as input.
> -The SHA-384 and SHA-512 functions can process a message of at most 2^128 - 1
> +The SHA-384, SHA-512, and SHA-512/256 functions can process a message
> +of at most 2^128 - 1

you could just say "The others can process" to avoid getting caught out
again.

jmc

>  bits as input.
>  .Pp
>  The SHA2 functions are considered to be more secure than the
> 

Reply via email to