Philip Guenther wrote:
> -             nutmp = read(uf, utmp, statbf.st_size)/sizeof(struct utmp);
> +             nutmp = pread(uf, utmp, statbf.st_size, 0)/sizeof(struct utmp);
>               dsyslog(LOG_DEBUG, "read %d utmp entries", nutmp);

I guess you're going to claim it was like this when you got here, but dividing
an unchecked pread() return is the craziest thing I've seen in ten minutes.

otherwise ok.

Reply via email to