> > The last commit to this file fixed two (void)asprintf calls.  Fix the
> > two remaining calls: depend on the ret buffer being set to NULL on
> > failure.
> 
> Personally, I would leave vltimexpire and pltimexpire initialized
> to NULL and avoid those else clauses.

Anything which makes the next review pass easier.  Correct idioms
should be easy to spot, incorrect ones also.  It's the middle ground
where the idiom isn't clear, that I despise.

Reply via email to