On Tue, Apr 11, 2017 at 09:35:13PM -0700, Philip Guenther wrote:
> On Wed, 12 Apr 2017, Michael W. Bombardieri wrote:
> > Building with VMM_DEBUG enabled failed because a printf() warning was 
> > treated as an error.
> ...
> >                     DPRINTF("%s: function 0x07 (SEFF) unsupported subleaf "
> > -                       "0x%llx not supported\n", __func__, *ecx);
> > +                       "0x%lx not supported\n", __func__,
> > +                       (unsigned long)*ecx);
> 
> Hmm, uint32_t is expected to be unsigned int in other printf formats in 
> the file (and elsewhere in the kernel), so I think the cast is unnecessary 
> here and we can just go with:
> 
> --- vmm.c     25 Mar 2017 22:24:01 -0000      1.26
> +++ vmm.c     12 Apr 2017 04:33:04 -0000
> @@ -4353,7 +4353,7 @@ vmm_handle_cpuid(struct vcpu *vcpu)
>               } else {
>                       /* Unsupported subleaf */
>                       DPRINTF("%s: function 0x07 (SEFF) unsupported subleaf "
> -                         "0x%llx not supported\n", __func__, *ecx);
> +                         "0x%x not supported\n", __func__, *ecx);
>                       *eax = 0;
>                       *ebx = 0;
>                       *ecx = 0;
>

ok mlarkin 

Reply via email to