Hello, The variable rv in vscsi_t2i() appears to always be zero and could be removed.
- Michael Index: src/sys/dev/vscsi.c =================================================================== RCS file: /cvs/src/sys/dev/vscsi.c,v retrieving revision 1.41 diff -u -p -u -r1.41 vscsi.c --- src/sys/dev/vscsi.c 12 Feb 2017 17:12:37 -0000 1.41 +++ src/sys/dev/vscsi.c 30 Mar 2017 08:16:27 -0000 @@ -429,7 +429,6 @@ vscsi_t2i(struct vscsi_softc *sc, struct { struct vscsi_ccb *ccb; struct scsi_xfer *xs; - int rv = 0; TAILQ_FOREACH(ccb, &sc->sc_ccb_t2i, ccb_entry) { if (ccb->ccb_tag == t2i->tag) @@ -464,7 +463,7 @@ vscsi_t2i(struct vscsi_softc *sc, struct vscsi_done(sc, ccb); - return (rv); + return (0); } struct vscsi_devevent_task {