Todd C. Miller:

> >             case FATAL:
> > -                   if (!interactive)
> > -                           fprintf(stderr, garrulous ?
> > -                               "script, line %d: %s\n" : "",
> > -                               lineno, errmsg);
> > -                   else
> > -                           fprintf(stderr, garrulous ? "%s\n" : "",
> > -                               errmsg);
> > +                   if (!interactive) {
> > +                           if (garrulous)
> > +                                   fprintf(stderr,
> > +                                       "script, line %d: %s\n",
> > +                                       lineno, errmsg);
> > +                   } else if (garrulous)
> > +                           fprintf(stderr, "%s\n", errmsg);
> 
> Would this be better as:
> 
>                       if (garrulous) {
>                               if (!interactive)
>                                       fprintf(stderr, "script, line %d: %s\n",
>                                           lineno, errmsg);
>                               else
>                                       fprintf(stderr, "%s\n", errmsg);
>                       }

The cases before and after follow the

        if (!interactive) {
                if (garrulous)
                        ...
        
pattern.  *shrug*

-- 
Christian "naddy" Weisgerber                          [email protected]

Reply via email to