In that case I'd rather just have a general else like you said.
I'll commit it in a bit if you don't beat me to it :) thanks!
On 19:27 Mon 08 May , Stefan Sperling wrote:
> On Mon, May 08, 2017 at 05:35:26PM +0100, Ricardo Mestre wrote:
> > Hi tech@
> >
> > During stsp@'s effort to merge rtwn(4) and urtwn(4), more specifically since
> > r1.6 of /cvs/src/sys/dev/ic/rtwn.c, my urtwn(4) device started showing in
> > dmesg
> > with a capable baseband of 0T0R (only noticed it today!):
> >
> > urtwn0: MAC/BB RTL8188EU, RF 6052 0T0R, address xx:xx:xx:xx:xx:xx
> >
> > Since according to urtwn(4)'s manpage both RTL8188C and RTL8188E chips have
> > a
> > 1T1R capable baseband please find below a patch to correct this.
> >
> > OK?
>
> 8192c is the only MIMO chip supported by this driver. All other chips
> are 1T1R ones. We could make the 1T1R case a general 'else' clause
> instead of an 'else if', as in:
>
> - } else if (sc->chip & RTWN_CHIP_88C) {
> + } else {
>
> But either way, OK by me. Thank you for hunting this down.
