On Fri, May 26, 2017 at 10:15:37PM +0200, Sebastian Benoit wrote: > Peter Hessler([email protected]) on 2017.05.26 21:40:49 +0200: > > On 2017 May 26 (Fri) at 20:01:00 +0200 (+0200), Peter Hessler wrote: > > :Apropos of "I found it", I implemented support for RFC 7607. It's a > > :super short RFC, but basically it forbids use of AS 0 anywhere. > > : > > :OK? > > : > > : > > > > Fixed some denglish in an error message, mention the RFC in the man > > page, and don't take down the session if we receive AS0 in the path. > > > > > > Index: bgpd.8 > > =================================================================== > > RCS file: /cvs/openbsd/src/usr.sbin/bgpd/bgpd.8,v > > retrieving revision 1.52 > > diff -u -p -u -p -r1.52 bgpd.8 > > --- bgpd.8 19 Feb 2017 11:38:24 -0000 1.52 > > +++ bgpd.8 26 May 2017 18:29:49 -0000 > > @@ -357,6 +357,16 @@ control socket > > .Re > > .Pp > > .Rs > > +.%A W. Kumari > > +.%A R. Bush > > +.%A H. Schiller > > +.%A K. Patel > > +.%D August 2015 > > +.%R RFC 7607 > > +.%T Codification of AS 0 Processing > > diff is ok, but please consider this: > > i think we should limit the list to the features we support so > that users can check if a certain something should work or not. > > this is not a feature, this is a protocol clarification/stability issue. > > otherwise the list gets longer and useless. > > if you leave this out, put a /* rfc 7607 */ comment next to the > aspath_extract() below. >
longer, but not neccesarily useless. if you try and pick a subset of rfcs to mention, no one will guess their relevance. what does it cost? people uninterested skip the section anyway. why leave people wondering whether such and such is implemented> jmc
