On Sat, May 27, 2017 at 11:07:00AM +0200, Stefan Fritsch wrote: > NVM_ADMIN_DEL_IOCQ does not need prp1 (just as NVM_ADMIN_DEL_IOSQ). > Remove what is likely a cut'n'paste error from the *_ADD_* code. > > ok?
Tested on X270. No regression noticed. > > --- sys/dev/ic/nvme.c > +++ sys/dev/ic/nvme.c > @@ -1120,7 +1120,6 @@ nvme_q_delete(struct nvme_softc *sc, struct nvme_queue > *q) > > memset(&sqe, 0, sizeof(sqe)); > sqe.opcode = NVM_ADMIN_DEL_IOCQ; > - htolem64(&sqe.prp1, NVME_DMA_DVA(q->q_sq_dmamem)); > htolem16(&sqe.qid, q->q_id); > > rv = nvme_poll(sc, sc->sc_admin_q, ccb, nvme_sqe_fill); > -- :wq Claudio
