Hello,
On Sat, May 27, 2017 at 08:45:31PM +0200, Martin Pieuchot wrote:
> On 27/05/17(Sat) 17:33, Alexandr Nedvedicky wrote:
> > Hello,
> >
> > On Fri, May 26, 2017 at 04:54:57PM +0200, Martin Pieuchot wrote:
> > > The global list of softc is *not* accessed in the input path, so it
> > > doesn't need splnet().
> > >
> > > ioctl(2) handlers are already executed with the NET_LOCK() held, so
> > > splnet() is superfluous.
> >
> > changes look good to me, but still have a question:
> >
> > what is the plan for splnet()/splx() in trunk_init() and trunk_stop()
> > functions. It seems to me they are executed through ioctl(2) only,
> > so we can also let them go. or you want to leave it for another day?
>
> You're right! Plus these functions are only present for lacp and just
> schedule a timeout.
>
> So we can get rid of them as well. Updated diff below.
>
it looks good to me
OK sashan@
