> > > +static const char *bgpnotify_minor_fsm[] = { > > > + NULL, "In OpenSent State", "In OpenConfirm State", > > > + "In Established State", > > > +}; > > > > and maybe s/NULL/"Unspecified Error"/ > > If it's NULL, then tcpdump will print out the number: > > if (p == NULL) { > snprintf(buf, sizeof(buf), "#%d", minor);
Yes, that is better because it provides more detail.