> Date: Thu, 1 Jun 2017 13:33:05 +0200 > From: Christian Weisgerber <na...@mips.inka.de> > > >From kettenis@'s corresponding commit on amd64: > > Remove branch prediction hints from conditional branch instructions. > These hints are not recognized by clang's builtin assembler and > the opcode prefixes they generate have been no-ops for all CPUs > after the Pentium 4. > > Admittedly, CPUs <= Pentium 4 are the target for i386, but I think > we can afford the loss of this micro-optimization. > > ok?
Agreed; ok kettenis@ > Index: arch/i386/SYS.h > =================================================================== > RCS file: /cvs/src/lib/libc/arch/i386/SYS.h,v > retrieving revision 1.25 > diff -u -p -r1.25 SYS.h > --- arch/i386/SYS.h 7 May 2016 19:05:21 -0000 1.25 > +++ arch/i386/SYS.h 31 May 2017 22:52:21 -0000 > @@ -89,7 +89,7 @@ > movl $-1, %eax; \ > movl $-1, %edx /* for lseek */ > #define HANDLE_ERRNO() \ > - jnc,pt 99f; \ > + jnc 99f; \ > SET_ERRNO(); \ > 99: > > -- > Christian "naddy" Weisgerber na...@mips.inka.de > >
