On Tue, Jun 27, 2017 at 12:55:52AM +0300, corsah wrote: > > Hello, > Editor commands for disklabel can be properly terminated with just "q\n" > and do not require the additional newline. The second "\n" was included > when printf replaced echo, which had been adding an extra by default. > It appears that disklabel will even interpret the last command with zero > trailing newlines, but leaving one is probably better for consistency. > First diff submission; any criticism welcome.
Your mailer ate some leading whitespace in the patch, hence the patch doesn't apply. Usually webmail clients aren't well suited for patches since they mangle whitespace at their will. There's also something odd with the encoding of your mail: https://marc.info/?l=openbsd-tech&m=149851517829174&w=2 In any case, the diff itself looks good to me and makes these horrible commands a bit less horrible, so I'll commit it tomorrow, unless someone else wants to commit it with my ok. Index: softraid.4 =================================================================== RCS file: /var/cvs/src/share/man/man4/softraid.4,v retrieving revision 1.41 diff -u -p -r1.41 softraid.4 --- softraid.4 14 Apr 2015 19:10:13 -0000 1.41 +++ softraid.4 26 Jun 2017 22:30:58 -0000 @@ -128,9 +128,9 @@ Initialize the partition tables of all d .Pp Now create RAID partitions on all disks: .Bd -literal -offset indent -# printf "a\en\en\en\enRAID\enw\enq\en\en" | disklabel -E wd1 -# printf "a\en\en\en\enRAID\enw\enq\en\en" | disklabel -E wd2 -# printf "a\en\en\en\enRAID\enw\enq\en\en" | disklabel -E wd3 +# printf "a\en\en\en\enRAID\enw\enq\en" | disklabel -E wd1 +# printf "a\en\en\en\enRAID\enw\enq\en" | disklabel -E wd2 +# printf "a\en\en\en\enRAID\enw\enq\en" | disklabel -E wd3 .Ed .Pp Assemble the RAID volume: @@ -154,7 +154,7 @@ Initialize the partition table and creat new RAID volume: .Bd -literal -offset indent # fdisk -iy sd0 -# printf "a\en\en\en\en4.2BSD\enw\enq\en\en" | disklabel -E sd0 +# printf "a\en\en\en\en4.2BSD\enw\enq\en" | disklabel -E sd0 # newfs /dev/rsd0a .Ed .Pp
