On Sat, Jul 01, 2017 at 11:59:59PM -0400, Rob Pierce wrote:
> Remove variable assignment in declaration and add whitespace to improve
> readability. No functional change.
>
> Rob
Fine with me. I think either style is fine, though.
>
> Index: ifstated.c
> ===================================================================
> RCS file: /cvs/src/usr.sbin/ifstated/ifstated.c,v
> retrieving revision 1.45
> diff -u -p -r1.45 ifstated.c
> --- ifstated.c 28 Jun 2017 11:10:08 -0000 1.45
> +++ ifstated.c 2 Jul 2017 03:52:04 -0000
> @@ -527,7 +527,9 @@ adjust_expressions(struct ifsd_expressio
> void
> eval_state(struct ifsd_state *state)
> {
> - struct ifsd_external *external = TAILQ_FIRST(&state->external_tests);
> + struct ifsd_external *external;
> +
> + external = TAILQ_FIRST(&state->external_tests);
> if (external == NULL || external->lastexec >= state->entered ||
> external->lastexec == 0) {
> do_action(state->always);
>
