On Wed, Jul 05, 2017 at 07:51:15AM +0000, Florian Obser wrote:
On Tue, Jul 04, 2017 at 09:43:59PM +0200, Klemens Nanni wrote:
On Tue, Jul 04, 2017 at 04:00:43PM +0000, Florian Obser wrote:
>yeah, this is arse backwards, I'm willing to commit the oposite though,
>i.e. get rid of the void casts for printf
Casts removed, cosecutive calls merged where suitable.
Feedback/OK?
not quite, you mix mechanical changes (remove of (void)) with the merges.
That made review much more difficult. Also it shouldn't be one commit.
I disentangled it and removed a few more (void)s.
I'm not sure I agree with the printf merges, it seems to make it more
difficult to read, also it no longer applies. If you feel strongly
about it, can you re-submit those changes on top of what's in cvs now
and explain why it's a good thing. It is possible that I missed
something because of all the (void) noise. Thanks!
That's quite fine already, thanks for massaging it in.
