> So I'd say for cases like src == dst we don't have to guarantee that > bytes are swapped.
and you've audited all the callers to this function? > Agreed, I haven't checked for bad/dangerous usage in existing code for > reasons explained above. No you haven't. Completely irresponsible. What a waste of time.